bkonold commented on a change in pull request #1236: SAMZA-2419: removing
duplicate cleaning of stores
URL: https://github.com/apache/samza/pull/1236#discussion_r358530751
##########
File path:
samza-core/src/main/java/org/apache/samza/storage/TransactionalStateTaskRestoreManager.java
##########
@@ -243,17 +243,6 @@ static StoreActions getStoreActions(
timeSinceLastCheckpointInMs = System.currentTimeMillis() -
checkpointedChangelogOffset.getCheckpointId().getMillis();
}
-
- // if the clean.store.start config is set, delete the currentDir,
restore from oldest offset to checkpointed
- if (storageEngine.getStoreProperties().isPersistedToDisk() && new
StorageConfig(
- config).getCleanLoggedStoreDirsOnStart(storeName)) {
- File currentDir =
storageManagerUtil.getTaskStoreDir(nonLoggedStoreBaseDirectory, storeName,
taskName, taskMode);
Review comment:
@prateekm @rmatharu shouldn't we be cleaning from loggedStoreBaseDirectory
here (in the non-deleted copy of this code block)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
