Sanil15 commented on a change in pull request #1227: SAMZA-2404: [SEP-22] Container Placement Handler for dispatching container placement messages between metastore and JobCoordinator URL: https://github.com/apache/samza/pull/1227#discussion_r365321987
########## File path: samza-core/src/main/java/org/apache/samza/clustermanager/container/placement/ContainerPlacementMessageObjectMapper.java ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.clustermanager.container.placement; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import java.util.UUID; +import org.apache.samza.container.placement.ContainerPlacementMessage; +import org.apache.samza.container.placement.ContainerPlacementRequestMessage; +import org.apache.samza.container.placement.ContainerPlacementResponseMessage; +import org.codehaus.jackson.JsonGenerator; +import org.codehaus.jackson.JsonNode; +import org.codehaus.jackson.JsonParser; +import org.codehaus.jackson.ObjectCodec; +import org.codehaus.jackson.Version; +import org.codehaus.jackson.map.DeserializationContext; +import org.codehaus.jackson.map.JsonDeserializer; +import org.codehaus.jackson.map.JsonSerializer; +import org.codehaus.jackson.map.ObjectMapper; +import org.codehaus.jackson.map.SerializerProvider; +import org.codehaus.jackson.map.jsontype.NamedType; +import org.codehaus.jackson.map.module.SimpleModule; + +/** + * Object mapper for serializing and deserializing Container placement messages + */ +public class ContainerPlacementMessageObjectMapper { + + private ContainerPlacementMessageObjectMapper() { + } + + static ObjectMapper getObjectMapper() { + ObjectMapper objectMapper = new ObjectMapper(); + SimpleModule module = new SimpleModule("ContainerPlacementModule", new Version(1, 0, 0, "")); + module.addSerializer(ContainerPlacementMessage.class, + new ContainerPlacementMessageObjectMapper.ContainerPlacementMessageSerializer()); + module.addDeserializer(ContainerPlacementMessage.class, + new ContainerPlacementMessageObjectMapper.ContainerPlacementMessageDeserializer()); + objectMapper.registerModule(module); + objectMapper.registerSubtypes(new NamedType(ContainerPlacementResponseMessage.class)); + objectMapper.registerSubtypes(new NamedType(ContainerPlacementRequestMessage.class)); + return objectMapper; + } + + static class ContainerPlacementMessageSerializer extends JsonSerializer<ContainerPlacementMessage> { + @Override + public void serialize(ContainerPlacementMessage value, JsonGenerator jsonGenerator, SerializerProvider provider) + throws IOException { + Map<String, Object> containerPlacementMessageMap = new HashMap<String, Object>(); + if (value instanceof ContainerPlacementRequestMessage) { + containerPlacementMessageMap.put("subType", ContainerPlacementRequestMessage.class.getName()); + } else if (value instanceof ContainerPlacementResponseMessage) { + containerPlacementMessageMap.put("subType", ContainerPlacementResponseMessage.class.getName()); + containerPlacementMessageMap.put("responseMessage", + ((ContainerPlacementResponseMessage) value).getResponseMessage()); + } + containerPlacementMessageMap.put("uuid", value.getUuid().toString()); + containerPlacementMessageMap.put("applicationId", value.getApplicationId()); + containerPlacementMessageMap.put("processorId", value.getProcessorId()); + containerPlacementMessageMap.put("destinationHost", value.getDestinationHost()); + containerPlacementMessageMap.put("requestExpiry", value.getRequestExpiry()); + containerPlacementMessageMap.put("statusCode", value.getStatusCode().name()); + jsonGenerator.writeObject(containerPlacementMessageMap); + } + } + + static class ContainerPlacementMessageDeserializer extends JsonDeserializer<ContainerPlacementMessage> { + @Override + public ContainerPlacementMessage deserialize(JsonParser jsonParser, DeserializationContext context) + throws IOException { + ObjectCodec oc = jsonParser.getCodec(); + JsonNode node = oc.readTree(jsonParser); + String subType = node.get("subType").getTextValue(); + String applicationId = node.get("applicationId").getTextValue(); + String processorId = node.get("processorId").getTextValue(); + String destinationHost = node.get("destinationHost").getTextValue(); + Long requestExpiry = node.get("requestExpiry").isNull() ? null : node.get("requestExpiry").getLongValue(); + ContainerPlacementMessage.StatusCode statusCode = null; + UUID uuid = UUID.fromString(node.get("uuid").getTextValue()); + for (ContainerPlacementMessage.StatusCode code : ContainerPlacementMessage.StatusCode.values()) { + if (code.name().equals(node.get("statusCode").getTextValue())) { + statusCode = code; + } + } + ContainerPlacementMessage message = null; + if (subType.equals(ContainerPlacementRequestMessage.class.getName())) { + message = new ContainerPlacementRequestMessage(uuid, applicationId, processorId, destinationHost, requestExpiry); + } else if (subType.equals(ContainerPlacementResponseMessage.class.getName())) { + String responseMessage = node.get("responseMessage").getTextValue(); + message = new ContainerPlacementResponseMessage(uuid, applicationId, processorId, destinationHost, requestExpiry, + statusCode, responseMessage); + } + return message; Review comment: "You can define yours in separate files but link them in SamzaObjectMapper since this is a part of Samza." SamzaObjectMapper class is only used for JobModel serde, I think maybe that is the reason @dnishimura also did not link Startpoint object mappers with it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
