cameronlee314 commented on a change in pull request #1266: SAMZA-2452 : Adding
internal autosizing related configs
URL: https://github.com/apache/samza/pull/1266#discussion_r375472331
##########
File path: samza-core/src/test/java/org/apache/samza/config/TestJobConfig.java
##########
@@ -610,11 +610,6 @@ public void testGetTaskOptsAutosizingDisabled() {
ShellCommandConfig shellCommandConfig =
new ShellCommandConfig(new
MapConfig(ImmutableMap.of(JobConfig.JOB_AUTOSIZING_ENABLED, "false")));
assertEquals(Option.empty(), shellCommandConfig.getTaskOpts());
-
- String taskOpts = "-Dproperty=value";
- shellCommandConfig = new ShellCommandConfig(new MapConfig(
- ImmutableMap.of(ShellCommandConfig.TASK_JVM_OPTS(), taskOpts,
JobConfig.JOB_AUTOSIZING_ENABLED, "false")));
- assertEquals(Option.apply(taskOpts), shellCommandConfig.getTaskOpts());
Review comment:
I don't think this should be removed. It is actually a different test case
(i.e. autosizing is disabled).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
