rmatharu commented on a change in pull request #1281: SAMZA-2378: Container
Placements support for Standby containers enabled jobs
URL: https://github.com/apache/samza/pull/1281#discussion_r382824102
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerManager.java
##########
@@ -435,32 +459,59 @@ private boolean
deQueueAction(ContainerPlacementRequestMessage requestMessage) {
/**
* A valid container placement action needs a valid processor id. Duplicate
actions are handled by de-duping on uuid.
+ * If standby containers are enabled destination host requested must meet
standby constraints
*
* @param requestMessage container placement request message
* @return Pair<ContainerPlacementMessage.StatusCode, String> which is
status code & response suggesting if the request is valid
*/
private Pair<ContainerPlacementMessage.StatusCode, String>
validatePlacementAction(ContainerPlacementRequestMessage requestMessage) {
- String errorMessagePrefix = String.format("ContainerPlacement request: %s
is rejected due to", requestMessage);
+ String errorMessagePrefix =
ContainerPlacementMessage.StatusCode.BAD_REQUEST + " reason: ";
Review comment:
Instead can we define errorMessage here
as ContainerPlacementMessage.StatusCode.BAD_REQUEST + " reason: %s"
and later String.format(errorMessage, reason);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
