rmatharu commented on a change in pull request #1301: New kv metric
URL: https://github.com/apache/samza/pull/1301#discussion_r387912564
##########
File path:
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStoreMetrics.scala
##########
@@ -36,6 +35,10 @@ class SerializedKeyValueStoreMetrics(
val bytesSerialized = newCounter("bytes-serialized")
val bytesDeserialized = newCounter("bytes-deserialized")
val maxRecordSizeBytes = newGauge("max-record-size-bytes", 0L)
+ val record_key_size_percentiles =
java.util.Arrays.asList[java.lang.Double](10D, 50D, 90D, 99D)
+ val record_value_size_percentiles =
java.util.Arrays.asList[java.lang.Double](10D, 50D, 90D, 99D)
+ val recordKeySizeBytes =
newHistogram("key-size-bytes-histogram",record_key_size_percentiles )
+ val recordValueSizeBytes = newHistogram("value-size-bytes-histogram",
record_value_size_percentiles)
Review comment:
Maybe add javadocs to explain how this works, the histogram stores counts
for each percentile range?
and the count for each range is emitted as a gauge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
