cameronlee314 commented on a change in pull request #1344: SAMZA-2510:
Incorrect shutdown status due to race between runloop and process callback
thread
URL: https://github.com/apache/samza/pull/1344#discussion_r408511598
##########
File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java
##########
@@ -185,6 +180,11 @@ public void run() {
containerMetrics.utilization().set(((double) activeNs) / totalNs);
}
}
+
+ if (throwable != null) {
Review comment:
Could you please add a note somewhere (maybe javadoc and/or PR description)
about this scenario? The PR title/description seems to refer to the general
shutdown case (which would include `RunLoop.shutdown`), but it looks like you
are focusing on the end-of-stream shutdown case in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
