Sanil15 commented on a change in pull request #1347: SAMZA-2511 : Adding logic
to handle container stop fail
URL: https://github.com/apache/samza/pull/1347#discussion_r409215717
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java
##########
@@ -126,6 +126,30 @@ public void handleContainerLaunchFail(String containerID,
String resourceID,
}
}
+ /**
+ * Handle the failed stop for a container, based on
+ * Case 1. If it is standby container, continue the failover
+ * Case 2. If it is an active container, then log a warning and return.
+ * @param containerID the ID of the container that has failed
Review comment:
nit: @param containerID logical id ex 0,1,2 of the failed samza container
@param resourceID physical id of the failed container
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
