bkonold commented on a change in pull request #1364:
URL: https://github.com/apache/samza/pull/1364#discussion_r427806699
##########
File path:
samza-azure/src/main/java/org/apache/samza/system/azureblob/utils/BlobMetadataContext.java
##########
@@ -25,10 +25,12 @@
public class BlobMetadataContext {
private final String streamName;
private final long blobSize;
+ private final long numberOfMessagesInBlob;
- public BlobMetadataContext(String streamName, long blobSize) {
+ public BlobMetadataContext(String streamName, long blobSize, long
numberOfMessagesInBlob) {
this.streamName = streamName;
this.blobSize = blobSize;
+ this.numberOfMessagesInBlob = numberOfMessagesInBlob;
Review comment:
I see. Thanks for explaining.
I notice that the interface of the generator takes a BlobMetadataContext and
returns a Map<String,String>; out of curiosity, is it intended that a generator
may have additional metadata (beyond what is carried within the
BlobMetadataContext) to attach to the blob?
##########
File path:
samza-azure/src/main/java/org/apache/samza/system/azureblob/avro/AzureBlobOutputStream.java
##########
@@ -85,6 +85,7 @@
private volatile boolean isClosed = false;
private long totalUploadedBlockSize = 0;
+ private long totalNumberOfRecordsInBlob = 0;
Review comment:
Cool. That's fine then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
