bkonold commented on a change in pull request #1382:
URL: https://github.com/apache/samza/pull/1382#discussion_r439659738
##########
File path:
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
##########
@@ -82,7 +83,6 @@ class TestKafkaCheckpointManager extends
KafkaServerTestHarness {
val spec = new KafkaStreamSpec("id", checkpointTopic,
checkpointSystemName, 1, 1, props)
val checkPointManager = Mockito.spy(new KafkaCheckpointManager(spec, new
MockSystemFactory, false, config, new NoOpMetricsRegistry))
Review comment:
Fair enough. Better than the test being disabled.
I'd be more worried if all invocations of
`KafkaCheckpointManager.getSystemProducer` were stubbed using the spy, but it
looks to be specifically targeting the second invocation (the first is during
construction), so the test is at least not completely masking away the contract
with `SystemFactory`.
You can ignore this comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
