b-slim commented on a change in pull request #1384: URL: https://github.com/apache/samza/pull/1384#discussion_r440327510
########## File path: samza-sql/src/main/java/org/apache/samza/sql/planner/SamzaSqlFilterRemoteJoinRule.java ########## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.sql.planner; + +import java.util.Map; +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.plan.RelOptRuleOperand; +import org.apache.calcite.plan.RelOptUtil; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Filter; +import org.apache.calcite.rel.core.Join; +import org.apache.calcite.rel.core.JoinRelType; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.rex.RexUtil; +import org.apache.calcite.tools.RelBuilder; +import org.apache.calcite.tools.RelBuilderFactory; + +import java.util.ArrayList; +import java.util.List; +import org.apache.samza.sql.interfaces.SqlIOConfig; +import org.apache.samza.sql.translator.JoinInputNode; +import org.apache.samza.sql.translator.JoinInputNode.InputType; + +/** + * Planner rule for remote table joins that pushes filters above and + * within a join node into its children nodes. + * This class is customized form of Calcite's {@link org.apache.calcite.rel.rules.FilterJoinRule} for + * remote table joins. + */ +public abstract class SamzaSqlFilterRemoteJoinRule extends RelOptRule { + /** Whether to try to strengthen join-type. */ + private final boolean smart; + + Map<String, SqlIOConfig> systemStreamConfigBySource; + + //~ Constructors ----------------------------------------------------------- + + /** + * Creates a FilterJoinRule with an explicit root operand and + * factories. + */ + protected SamzaSqlFilterRemoteJoinRule(RelOptRuleOperand operand, String id, + boolean smart, RelBuilderFactory relBuilderFactory, Map<String, SqlIOConfig> systemStreamConfigBySource) { + super(operand, relBuilderFactory, "SamzaSqlFilterRemoteJoinRule:" + id); + this.smart = smart; + this.systemStreamConfigBySource = systemStreamConfigBySource; + } + + //~ Methods ---------------------------------------------------------------- + + protected void perform(RelOptRuleCall call, Filter filter, Review comment: As far I can tell it is only testing if filter is on the good side of the join, seems to me most of the work can be done at the onMatch, we can just extend and override onMatch ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
