lakshmi-manasa-g commented on a change in pull request #1385:
URL: https://github.com/apache/samza/pull/1385#discussion_r443066459
##########
File path:
samza-core/src/main/java/org/apache/samza/storage/TaskSideInputHandler.java
##########
@@ -259,6 +277,44 @@ public void stop() {
return oldestOffsets;
}
+ /**
+ * Checks if whether the given offset for the SSP has reached the latest
offset (determined at init),
Review comment:
please clarify what caught up means - because when starting offset =
newest offset - it is caught up but the comparator result says not caught up.
Oe does consuming newset offset qualify as caught up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
