sborya commented on a change in pull request #1394:
URL: https://github.com/apache/samza/pull/1394#discussion_r445753884
##########
File path: build.gradle
##########
@@ -422,6 +423,11 @@ project(":samza-kafka_$scalaSuffix") {
testRuntime "org.slf4j:slf4j-simple:$slf4jVersion"
}
+ checkstyle {
+ configFile = new File(rootDir, "checkstyle/checkstyle.xml")
+ toolVersion = "$checkstyleVersion"
Review comment:
where is it set?
##########
File path: checkstyle/checkstyle-suppressions.xml
##########
@@ -25,7 +25,10 @@
<suppress checks="ConstantName"
files="ApplicationStatus.java"
lines="26-29"/>
+ <!-- don't require FQDNs to be used in API javadocs -->
<suppress id="preventJavadocUnusedImports"
files=".*samza-api.*"/>
+ <!-- don't require FQDNs to be used in descriptor javadocs -->
+ <suppress
files="samza-kafka/src/main/java/org/apache/samza/system/kafka/descriptors"
id="preventJavadocUnusedImports" />
Review comment:
why do we allow unused imports?
##########
File path: checkstyle/checkstyle-suppressions.xml
##########
@@ -25,7 +25,10 @@
<suppress checks="ConstantName"
files="ApplicationStatus.java"
lines="26-29"/>
+ <!-- don't require FQDNs to be used in API javadocs -->
Review comment:
I don't understand this comment and what is it relevant to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
