PanTheMan commented on a change in pull request #1326:
URL: https://github.com/apache/samza/pull/1326#discussion_r445887114
##########
File path:
samza-core/src/test/java/org/apache/samza/execution/TestJobGraphJsonGenerator.java
##########
@@ -368,6 +368,31 @@ public void testLegacyTaskApplication() throws Exception {
assertEquals(0, jsonObject.jobs.size());
}
+ @Test
+ public void testToJobGraphJson() throws Exception {
Review comment:
Could we also add more tests to test the other changed classes like
JobNodeJson? The test here only tests JobGraphJson
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
