rmatharu commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r463806408
##########
File path: samza-core/src/main/java/org/apache/samza/util/DiagnosticsUtil.java
##########
@@ -70,7 +70,7 @@ public static void writeMetadataFile(String jobName, String
jobId, String contai
MetricsHeader metricsHeader =
new MetricsHeader(jobName, jobId, "samza-container-" + containerId,
execEnvContainerId.orElse(""),
LocalContainerRunner.class.getName(),
Util.getTaskClassVersion(config), Util.getSamzaVersion(),
- Util.getLocalHost().getHostName(), System.currentTimeMillis(),
System.currentTimeMillis());
+ Util.getLocalHost().getHostName(), System.currentTimeMillis(),
System.currentTimeMillis(), config);
Review comment:
Why do we want to add the config to the metric-header?
That way the entire config map (potentially 10s of MB of data) will be
emitted in every message.
This is NOT what we want to do right?
Instead we want to emit it in the MetricsMessage, but exactly once at
container start (first message) not in every message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
