vishwajith-s commented on a change in pull request #1416:
URL: https://github.com/apache/samza/pull/1416#discussion_r470355265



##########
File path: samza-api/src/main/java/org/apache/samza/metrics/SamzaHistogram.java
##########
@@ -53,6 +53,7 @@ public SamzaHistogram(MetricsRegistry registry, String group, 
String name, List<
 
   public void update(long value) {
     histogram.update(value);
+    percentiles.forEach(x -> updateGaugeValues(x));

Review comment:
       Also by the way this code is being called from Brooklin code in Brooklin 
cluster. Not sure if the visit is called




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to