mynameborat commented on a change in pull request #1446:
URL: https://github.com/apache/samza/pull/1446#discussion_r543320208
##########
File path:
samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java
##########
@@ -38,6 +38,9 @@
private static final String CLUSTER_MANAGER_FACTORY =
"samza.cluster-manager.factory";
private static final String CLUSTER_MANAGER_FACTORY_DEFAULT =
"org.apache.samza.job.yarn.YarnResourceManagerFactory";
+ private static final String FAULT_DOMAIN_MANAGER_FACTORY =
"samza.fault-domain-manager.factory";
+ private static final String FAULT_DOMAIN_MANAGER_FACTORY_DEFAULT =
"org.apache.samza.job.yarn.RackManagerFactory";
Review comment:
should it be `YarnFaultDomainManagerFactory`?
Also, I feel the configuration should be
`cluster-manager.fault-domain-manager.factory` since we have an association of
the fault domain manager to the cluster manager.
what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
