lakshmi-manasa-g commented on a change in pull request #1470:
URL: https://github.com/apache/samza/pull/1470#discussion_r586719978



##########
File path: 
samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppender.java
##########
@@ -439,7 +439,7 @@ private void startTransferThread() {
    * Helper method to send a serialized log-event to the systemProducer, and 
increment respective methods.
    * @param serializedLogEvent
    */
-  private void sendEventToSystemProducer(byte[] serializedLogEvent) {
+  protected void sendEventToSystemProducer(byte[] serializedLogEvent) {

Review comment:
       yep, i did consider that option but decided against to avoid 
proliferating StreamAppender with one liner methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to