prateekm commented on a change in pull request #1483:
URL: https://github.com/apache/samza/pull/1483#discussion_r602469261



##########
File path: 
samza-core/src/main/java/org/apache/samza/task/StreamOperatorTask.java
##########
@@ -146,6 +146,11 @@ public final void processAsync(IncomingMessageEnvelope 
ime, MessageCollector col
               callback.complete();
             }
           });
+        } else {
+          // If InputOperator is not found in the operator graph for a given 
SystemStream, throw an exception else the
+          // job will timeout due to async task callback timeout 
(TaskCallbackTimeoutException)
+          callback.failure(new SamzaException(
+              String.format("InputOperator not found in OperatorGraph for %s", 
systemStream.toString())));

Review comment:
       Can we rephrase this message in terms users would understand (e.g. 
describe what they did wrong instead of the current state of the system)?. 
It'll also be useful to explain in the PR description when this can happen.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to