mynameborat commented on pull request #1518: URL: https://github.com/apache/samza/pull/1518#issuecomment-900775153
I remember something about the `MetricsSnapshotReporter` being instantiated within the `SamzaContainer` as well. Any plans to inject that as well from the higher layers e.g., `ContainerLaunchUtil` so that other components within can reuse the reporters? I think the change itself was not huge from the perspective of YARN although it had few considerations on the standalone front due to difference in lifecycle between `SamzaContainer` & `StreamProcessor` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
