ajothomas commented on a change in pull request #1560:
URL: https://github.com/apache/samza/pull/1560#discussion_r758656519
##########
File path:
samza-api/src/main/java/org/apache/samza/table/AsyncReadWriteTable.java
##########
@@ -90,6 +92,33 @@
*/
CompletableFuture<Void> putAllAsync(List<Entry<K, V>> entries, Object ...
args);
+ /**
+ * Asynchronously updates the record associated with the specified update
for a given key.
+ * If the update is attempted on a non-existent record, a default value can
be inserted in the table depending
+ * on the table's implementation.
+ *
+ * @param key the key with which the specified {@code value} is to be
associated.
+ * @param update the update applied to the record associated with a given
{@code key}.
+ * @param defaultValue the default value that is inserted in the table if
the update is applied to a non-existent record.
+ * @param args additional arguments
+ * @throws NullPointerException if the specified {@code key} is {@code null}.
+ * @return CompletableFuture for the operation
+ */
+ CompletableFuture<Void> updateAsync(K key, U update, @Nullable V
defaultValue, Object ... args);
Review comment:
Changed the update API by removing defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
