rayman7718 commented on a change in pull request #1580:
URL: https://github.com/apache/samza/pull/1580#discussion_r797235211



##########
File path: 
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java
##########
@@ -39,9 +41,10 @@ public static Runnable 
createRunLoop(scala.collection.immutable.Map<TaskName, Ru
       ExecutorService threadPool,
       long maxThrottlingDelayMs,
       SamzaContainerMetrics containerMetrics,
-      TaskConfig taskConfig,
+      Config config,

Review comment:
       Preferable to pass elastcitrity factor as the additional variable in 
addition to task-config, rather than the entire config object




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to