rmatharu commented on code in PR #1599:
URL: https://github.com/apache/samza/pull/1599#discussion_r864339360
##########
samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala:
##########
@@ -216,9 +216,19 @@ class OffsetManager(
* Set the last processed offset for a given SystemStreamPartition.
*/
def update(taskName: TaskName, systemStreamPartition: SystemStreamPartition,
offset: String) {
+ // without elasticity enabled, there is exactly one entry of an ssp in the
systemStreamPartitions map for a taskName
+ // with elasticity enabled, there is exactly one of the keyBuckets of an
ssp that a task consumes
+ // and hence exactly one entry of an ssp with keyBucket in in the
systemStreamPartitions map for a taskName
+ // hence from the given ssp, find its sspWithKeybucket for the task and
use that for updating lastProcessedOffsets
+ val sspWithKeyBucket = systemStreamPartitions.getOrElse(taskName,
Review Comment:
Will this work with Broadcast streams?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
