cameronlee314 opened a new pull request, #1604: URL: https://github.com/apache/samza/pull/1604
Issue: For environments in which apps run in isolated containers (e.g. Kubernetes), there is no need to have unique file names for container metadata files. It is much easier to find these files when they have static names instead of depending on the exec-env-container-id. A concrete Kubernetes use case for this is to be able to set the `terminationMessagePath` to this container metadata file in order to pass some information through to controllers. Changes: Add a new environment variable `CONTAINER_METADATA_FILENAME` which specifies the name of the container metadata file. API/usage changes: (backwards compatible) If `CONTAINER_METADATA_FILENAME` is specified, then use that for generating the container metadata file name. Otherwise, fall back to using the exec-env-container-id to generate the file name. Tests: Deployed in minikube and verified that the container metadata file matched the value set in the `CONTAINER_METADATA_FILENAME` environment variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
