mynameborat opened a new pull request, #1614: URL: https://github.com/apache/samza/pull/1614
**Summary**: Standby feature is broken for jobs that don't have explicit side inputs Change logged stores are treated as non-change logged for standby containers **Description**: [PR 1367](https://github.com/apache/samza/pull/1367) - Introduced a bug where jobs with no side inputs caused jobs to not bootstrap data for logged stores. The root cause was related to mutation of `taskSideInputStoreSSPs` as `changelogSSPs` that were added to it during initialization were ignored since the initialization of `hasSideInputs` happened before. [PR 1491](https://github.com/apache/samza/pull/1491) - Introduced a bug where the logged stores were incorrectly classified as non-logged stores for standby container resulting in discarding of state at the end of container lifecycle. The root cause was similar to above where `sideInputStoreNames` was initialized prior to updating `changelogSSPs` **Changes**: - Compute the final value for `taskSideInputStoreSSPS` as part of initialization - Compute the final value for `sideInputStoresNames` as part of initialization - Remove mutating side input related fields after initialization for standby flows **Tests**: - Added unit tests for new code - Validated standby failover and bootstrap characteristics of failed over container - Validated standby failover across both version of checkpoints (V1 and V2) **API Changes**: None **Usage Instructions**: None **Upgrade Instructions**: None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
