[GitHub] [samza] james-deee commented on a diff in pull request #1628: Get Samza to work with Java 11 (still works with Java 8)

[GitBox]

james-deee commented on code in PR #1628:
URL: https://github.com/apache/samza/pull/1628#discussion_r949607696


##########
samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala:
##########
@@ -366,16 +366,14 @@ class KafkaConfig(config: Config) extends 
ScalaMapConfig(config) {
     val properties = new Properties()
 
     if (isStreamMode) {
-      properties.putAll(ImmutableMap.of(
-        "cleanup.policy", "compact",
-        "segment.bytes", String.valueOf(segmentBytes),
-        "max.message.bytes", String.valueOf(maxMessageBytes)))
+      properties.put("cleanup.policy", "compact")

Review Comment:
   The putAll method has an ambiguous issue: 
https://github.com/scala/bug/issues/10418
   
   So just moving to single line puts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org