ajothomas opened a new pull request, #1629:
URL: https://github.com/apache/samza/pull/1629

   **Improvement:**
   
   This PR is a part of the Pipeline Drain work and aims to improve 
DrainUtils.writeDrainNotification method which write drain notifications to the 
metadata store. Currently, an external controller needs to supply the 
deployment id (runId).  The controller needs to have the knowledge of the 
current runId. For draining the current job, we should be able to retrieve the 
runId from the metadata store.
   
   **Changes:**
   
   - Add a new method `DrainUtils.writeDrainNotification` which just takes the 
metadata store as the parameter. In cluster based deployments, configs 
(including the runId of a job) are written to the metadata store prior to 
starting the Job Coordinator. The method will read the configs from the 
metadata store, get the runId and use that to write a DrainNotification to the 
metadata store  corresponding to the runId.
   
   **Tests:**
   
   - Changes in Unit tests for `DrainMonitor`
   - Changes in Integ test for Drain for High-level and Low-Level API- 
`DrainLowLevelApiIntegrationTest` & `DrainHighLevelApiIntegrationTest` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to