ajothomas commented on code in PR #1637:
URL: https://github.com/apache/samza/pull/1637#discussion_r1018501997
##########
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java:
##########
@@ -106,7 +110,10 @@ public void run() {
callback.failure(new SamzaException(msg));
}
};
- ScheduledFuture scheduledFuture = timer.schedule(timerTask, timeout,
TimeUnit.MILLISECONDS);
+
+ final ScheduledFuture scheduledFuture = isDraining &&
(envelope.isDrain() || envelope.isWatermark())
Review Comment:
Thanks, refactored the `TaskCallbackManager`'s `createCallback` method to
incorporate timeout and moved the logic to decide what timeout to use to the
`process()` method inside `AsyncTaskWorker`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
