ajothomas opened a new pull request, #1642: URL: https://github.com/apache/samza/pull/1642
# Summary The current `DrainNotification` is a concrete class tasked with signaling samza engine to clear intermediate state. It is currently inextensible and any changes to the class in the future to accommodate new features would make the class backward incompatible. As DrainNotifications are stored in the metadata store, we need to be make sure that it can be extended in a backward compatible way. # Changes - Convert `DrainNotification` to an abstract class. Add `BasicDrainNotification` to represent a standard drain operation which involves samza clearing intermediate streams and any system managed state. Treat `DrainNotification` and `BasicDrainNotification` as api by putting in under `samza-api` - Change `DrainNotificationObjectMapper` - Alter `DrainUtils` and `DrainMonitor` to accommodate the above changes # Tests - Tests for `DrainNotificationObjectMapper` - Tests for `DrainUtils` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
