mynameborat commented on code in PR #1651:
URL: https://github.com/apache/samza/pull/1651#discussion_r1087260223
##########
samza-core/src/main/java/org/apache/samza/zk/ZkLeaderElector.java:
##########
@@ -69,6 +71,7 @@ public ZkLeaderElector(String processorIdStr, ZkUtils
zkUtils) {
@VisibleForTesting
public ZkLeaderElector(String processorIdStr,
ZkUtils zkUtils,
+ @Nonnull
IZkDataListener previousProcessorChangeListener) {
this.processorIdStr = processorIdStr;
Review Comment:
The annotation doesn't do much and is mostly for readability. Moreover, the
annotation used in this from guava and I highly doubt anything is enforced
through the annotation.
That said, if there are no usages in the code, you can remove this
constructor. I am leaning towards making no change and have the tests use the
same constructor since the behavior of two constructors differ slightly with
validation on zkUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
