mynameborat commented on code in PR #1665:
URL: https://github.com/apache/samza/pull/1665#discussion_r1188792021
##########
settings.gradle:
##########
@@ -16,6 +16,39 @@
* specific language governing permissions and limitations
* under the License.
*/
+plugins {
+ id 'com.gradle.enterprise' version '3.13.1'
+ id 'com.gradle.common-custom-user-data-gradle-plugin' version '1.10'
+}
+
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+ server = "https://ge.apache.org";
+ buildScan {
+ capture { taskInputFiles = true }
+ uploadInBackground = !isCI
+ publishAlways()
+ publishIfAuthenticated()
+ obfuscation {
+ // This obfuscates the IP addresses of the build machine in the build
scan.
+ // Alternatively, the build scan will provide the hostname for
troubleshooting host-specific issues.
+ ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }
Review Comment:
Do we only have the build machine address as part of the scans or are there
more? If so, this seems to obfuscate all of those addresses? Will that have any
impact on navigating build scans?
##########
settings.gradle:
##########
@@ -16,6 +16,39 @@
* specific language governing permissions and limitations
* under the License.
*/
+plugins {
+ id 'com.gradle.enterprise' version '3.13.1'
+ id 'com.gradle.common-custom-user-data-gradle-plugin' version '1.10'
+}
+
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+ server = "https://ge.apache.org";
+ buildScan {
+ capture { taskInputFiles = true }
+ uploadInBackground = !isCI
+ publishAlways()
+ publishIfAuthenticated()
+ obfuscation {
+ // This obfuscates the IP addresses of the build machine in the build
scan.
+ // Alternatively, the build scan will provide the hostname for
troubleshooting host-specific issues.
+ ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }
+ }
+ }
+}
+
+buildCache {
+ local {
+ enabled = !isCI
Review Comment:
why set this to false in case of CI? How does this impact build scans?
##########
settings.gradle:
##########
@@ -16,6 +16,39 @@
* specific language governing permissions and limitations
* under the License.
*/
+plugins {
+ id 'com.gradle.enterprise' version '3.13.1'
+ id 'com.gradle.common-custom-user-data-gradle-plugin' version '1.10'
+}
+
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+ server = "https://ge.apache.org";
+ buildScan {
+ capture { taskInputFiles = true }
+ uploadInBackground = !isCI
+ publishAlways()
+ publishIfAuthenticated()
+ obfuscation {
+ // This obfuscates the IP addresses of the build machine in the build
scan.
+ // Alternatively, the build scan will provide the hostname for
troubleshooting host-specific issues.
+ ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }
+ }
+ }
+}
+
+buildCache {
+ local {
+ enabled = !isCI
+ }
+
+ remote(gradleEnterprise.buildCache) {
+ enabled = false
+ }
Review Comment:
Wouldn't this help with improving e2e latency of CI flows? If not, when is
it beneficial to enable this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
