ehoner commented on code in PR #1662:
URL: https://github.com/apache/samza/pull/1662#discussion_r1224450052
##########
samza-azure/src/main/java/org/apache/samza/system/azureblob/avro/AzureBlobAvroWriter.java:
##########
@@ -108,19 +109,32 @@ public class AzureBlobAvroWriter implements
AzureBlobWriter {
private final String blobURLPrefix;
private final long maxBlobSize;
private final long maxRecordsPerBlob;
+ private final int initBufferSize;
private final boolean useRandomStringInBlobName;
private final Object currentDataFileWriterLock = new Object();
private volatile long recordsInCurrentBlob = 0;
private BlobMetadataGeneratorFactory blobMetadataGeneratorFactory;
private Config blobMetadataGeneratorConfig;
private String streamName;
+ @Deprecated
Review Comment:
I was deprecating this because it wasn't clear to me that the class _should_
have multiple constructors. And marking as deprecated avoids the major version
bump requirement for public APIs. I believe the expectation is that config
values are not expected to be referenced throughout the code, but maybe default
values are acceptable.
I will follow up with Samza committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
