ehoner opened a new pull request, #1670:
URL: https://github.com/apache/samza/pull/1670
Symptom: self-reported bug.
Cause: New parameter, `ReceiverOptions`, is unused during API call. The
parameter is required to pass the offset to the underlying `EventHub`
implementation. The change was required library changes in #1660.
Changes: The parameter is being used when creating the `PartitionReceiver`.
This change was required in two places, however, only
[one](https://github.com/apache/samza/pull/1660#discussion_r1228789636) was
done incorrectly. Both sites were updated so the code structure would be
similar.
Tests: No new tests were added. Existing tests did not identify the mistake
because of the reliance on a custom mock. After the change, the tests failed
until the mock was updated to reflect the change in API usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
