Sanil15 commented on code in PR #1680:
URL: https://github.com/apache/samza/pull/1680#discussion_r1296219539


##########
samza-core/src/main/scala/org/apache/samza/storage/SideInputsManager.java:
##########
@@ -507,4 +496,32 @@ private static boolean awaitSideInputTasks(Map<TaskName, 
CountDownLatch> sideInp
     }
     return true;
   }
+
+  private static class SideInputRunLoopConfig extends RunLoopConfig {
+
+    public SideInputRunLoopConfig(Config config) {
+      super(config);
+    }
+
+    @Override
+    public int getMaxConcurrency() {

Review Comment:
   minor: Lets add comment here for someone in future to have the context:
   Sideinput only processes single message per task and add the no windowing 
below 
    
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to