dxichen commented on code in PR #1682:
URL: https://github.com/apache/samza/pull/1682#discussion_r1297761986
##########
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManagerRestoreUtil.java:
##########
@@ -185,17 +185,6 @@ private static CompletableFuture<Map<TaskName,
Checkpoint>> restoreAllTaskInstan
throw new SamzaException(msg, ex); // wrap in unchecked
exception to throw from lambda
}
}
-
Review Comment:
by future here I mean if we chain `restoreDeletedSnapshots` future to the
restore such that it is always performed after restore and before the close
call avoiding the race condition during restore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
