shekhars-li commented on code in PR #1682:
URL: https://github.com/apache/samza/pull/1682#discussion_r1298697742
##########
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManagerRestoreUtil.java:
##########
@@ -133,8 +135,8 @@ private static CompletableFuture<Map<TaskName, Checkpoint>>
restoreAllTaskInstan
Config config, Map<TaskName, TaskInstanceMetrics> taskInstanceMetrics,
ExecutorService executor,
File loggedStoreDir, Set<String> forceRestoreTask) {
- Map<TaskName, CompletableFuture<Checkpoint>> newTaskCheckpoints = new
ConcurrentHashMap<>();
- List<Future<Void>> taskRestoreFutures = new ArrayList<>();
+ Map<TaskName, Checkpoint> newTaskCheckpoints = new ConcurrentHashMap<>();
+ Queue<Future<Void>> restoreAndCleanupFutures = new
ConcurrentLinkedQueue<>();
Review Comment:
Removed that. It was indeed unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
