dxichen commented on code in PR #1684:
URL: https://github.com/apache/samza/pull/1684#discussion_r1303615700
##########
samza-core/src/main/java/org/apache/samza/storage/blobstore/util/DirDiffUtil.java:
##########
@@ -168,11 +171,17 @@ public static BiPredicate<File, FileIndex>
areSameFile(boolean compareLargeFileC
// Don't compare file timestamps. The ctime of a local file just
restored will be different than the
// remote file, and will cause the file to be uploaded again during
the first commit after restore.
- areSameFiles = localFileAttrs.size() == remoteFileMetadata.getSize()
&&
-
groupCache.get(String.valueOf(Files.getAttribute(localFile.toPath(),
"unix:gid")),
- () ->
localFileAttrs.group().getName()).equals(remoteFileMetadata.getGroup()) &&
-
ownerCache.get(String.valueOf(Files.getAttribute(localFile.toPath(),
"unix:uid")),
- () ->
localFileAttrs.owner().getName()).equals(remoteFileMetadata.getOwner());
+ areSameFiles = localFileAttrs.size() == remoteFileMetadata.getSize();
Review Comment:
Synced up offline, SST files are immutable as per [original RocksDB
paper](https://scontent-sjc3-1.xx.fbcdn.net/v/t39.8562-6/260203686_676839503287444_5314493774276549632_n.pdf?_nc_cat=103&ccb=1-7&_nc_sid=ad8a9d&_nc_ohc=y92R003NFBMAX-5A9g8&_nc_ht=scontent-sjc3-1.xx&oh=00_AfAYFM8VJ8d_nyA0H3vlxKIQFDG-WXKGio_Nu2__r-Nevw&oe=64EACD7C).
Since we already checked the name and the size, these checks are sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
