ajothomas commented on code in PR #1708:
URL: https://github.com/apache/samza/pull/1708#discussion_r1847479336
##########
samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala:
##########
@@ -531,8 +563,11 @@ class TaskInstance(
"Saved exception under Caused By.", commitException.get())
}
} else {
+ commitExceptionCounter.set(0)
+ commitTimeoutCounter.set(0)
metrics.commitAsyncNs.update(System.nanoTime() - asyncStageStartNs)
metrics.commitNs.update(System.nanoTime() - commitStartNs)
+ metrics.lastAsyncCommitNs.set(System.nanoTime())
Review Comment:
Since we are adding configs here to skip commit exception, this metric might
have some utility in viewing when was the last commit. I would rather name it
as `lastCommitTimestampNs`.
Metrics like `commitNs`, `processns`, `windowns` have been used to quantify
the time taken for each of these steps. `lastAsyncCommitNs` is too similar to
`commitAsyncNs` so let's rename the metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
