[
https://issues.apache.org/jira/browse/SAMZA-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Riccomini updated SAMZA-115:
----------------------------------
Attachment: blocking-envelope-map-metric-name.png
SAMZA-115.0.patch
Attaching a patch.
1. Add a new parameter to BlockingEnvelopeMap to take metric group name.
2. Keep default for metric group name to be this.getClass.getName.
3. Make KafkaSystemConsumer use custom KafkaSystemConsumerMetrics group name to
match all other metrics.
Tested locally. Attaching a screenshot that shows metrics properly working with
the BlockingEnvelopeMap metrics (e.g. poll count) in the
KafkaSystemConsumerMetrics namespace.
> Allow metric group name overrides BlockingEnvelopeMap
> -----------------------------------------------------
>
> Key: SAMZA-115
> URL: https://issues.apache.org/jira/browse/SAMZA-115
> Project: Samza
> Issue Type: Bug
> Components: container, metrics
> Affects Versions: 0.6.0
> Reporter: Chris Riccomini
> Assignee: Chris Riccomini
> Labels: newbie
> Attachments: SAMZA-115.0.patch, blocking-envelope-map-metric-name.png
>
>
> BlockingEnvelopeMap currently hard-codes the metric group as
> this.getClass().getName(). This is generally OK, but there are occasions
> where we might want to override it (KafkaSystemConsumer being one of them).
> I think we should update the BlockingEnvelopeMap to take a parameter for the
> metrics name, and update KafkaSystemConsumer to use
> classOf[KafkaSystemConsumerMetrics].getName().
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
