[ 
https://issues.apache.org/jira/browse/SAMZA-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863687#comment-13863687
 ] 

Garry Turkington commented on SAMZA-120:
----------------------------------------

I assume in the use cases you mention there's no need to ever do something 
different if the queue is full (e.g. use offer instead of add) and blocking for 
submission is the right thing to do. +1 if so.

> Switch BlockingEnvelopeMap to use put instead of add
> ----------------------------------------------------
>
>                 Key: SAMZA-120
>                 URL: https://issues.apache.org/jira/browse/SAMZA-120
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Chris Riccomini
>         Attachments: SAMZA-120.0.patch
>
>
> BlockingEnvelopeMap currently uses .add instead of .put. This works fine, 
> since the queue is unbounded by default. However, there are use cases where 
> we want a bounded queue, and in such a case, it seems more sane to block, 
> rather than throw exceptions (as .add does), if the queue is full.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to