[ 
https://issues.apache.org/jira/browse/SAMZA-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887199#comment-13887199
 ] 

Steve Yates commented on SAMZA-96:
----------------------------------

This is ok Jakob, I have personally always found it helpful to have the 
application name as the first prefix and then we can add the metric after that 
if you wish?

If we wish to drop the SAMZA- prefix all together that's ok. I will review the 
MSR and take a look at what metrics it reports on. In this case we can;

1) SAMZA-{metric-name}-{thread-id}
2) {metric-name}-{thread-id}

I am happy to provide a patch with an implementation .

Cheers

> Improve DaemonThreadFactory to specify thread name, use that capability
> -----------------------------------------------------------------------
>
>                 Key: SAMZA-96
>                 URL: https://issues.apache.org/jira/browse/SAMZA-96
>             Project: Samza
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jakob Homan
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.7.0
>
>
> The DaemonThreadFactory class is used by  the JvmMetrics (line 42) and 
> MetricsSnapshotReporter (line 60) classes to create these classes' respective 
> threads, but it does not take any way to name the threads that the factory 
> creates.  When these threads are running and inspected in, say VisualVM, 
> they're boringly named Thread-6 or whatever.
> It'd be better to pass the factory a name or naming function and then name 
> the metrics threads so they're easier to work with from debuggers.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to