[
https://issues.apache.org/jira/browse/SAMZA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905760#comment-13905760
]
ASF GitHub Bot commented on SAMZA-47:
-------------------------------------
Github user criccomini commented on a diff in the pull request:
https://github.com/apache/incubator-samza/pull/1#discussion_r9874945
--- Diff:
samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java ---
@@ -21,7 +21,7 @@
import java.io.File;
-import org.apache.samza.config.Config;
+import org.apache.samza.container.SamzaContainerContext;
--- End diff --
I'm not seeing the SamzaContainerContext class. Did it get picked up in
your pull request?
> LevelDB and L1 cache use the same configuration value in KeyValueStorageEngine
> ------------------------------------------------------------------------------
>
> Key: SAMZA-47
> URL: https://issues.apache.org/jira/browse/SAMZA-47
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Jay Kreps
> Assignee: Martin Kleppmann
>
> Both seem to key off of
> cache.size
> This is not right. The L1 cache is caching a number of objects and leveldb is
> allocating a number of bytes. In general the leveldb cache should be big
> (tens of MBs) and the L1 cache small (a few thousand).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
