[ 
https://issues.apache.org/jira/browse/SAMZA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Kleppmann updated SAMZA-47:
----------------------------------

    Attachment: SAMZA-47.patch

Since the Github experiment didn't work out, here's the same as the pull 
request, in Reviewboard form: https://reviews.apache.org/r/18357/

I changed one thing since the pull request: in LevelDbKeyValueStore, renamed 
the {{config}} parameter to {{storeConfig}} (to clarify that it's just the 
configuration of that particular store, not the entire job config).

Also attaching the latest version as a patch.

> LevelDB and L1 cache use the same configuration value in KeyValueStorageEngine
> ------------------------------------------------------------------------------
>
>                 Key: SAMZA-47
>                 URL: https://issues.apache.org/jira/browse/SAMZA-47
>             Project: Samza
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jay Kreps
>            Assignee: Martin Kleppmann
>         Attachments: SAMZA-47.patch
>
>
> Both seem to key off of
>   cache.size
> This is not right. The L1 cache is caching a number of objects and leveldb is 
> allocating a number of bytes. In general the leveldb cache should be big 
> (tens of MBs) and the L1 cache small (a few thousand).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to