[ 
https://issues.apache.org/jira/browse/SAMZA-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961931#comment-13961931
 ] 

Chris Riccomini commented on SAMZA-58:
--------------------------------------

bq. 2. I keep progress 0 as we've not concluded a correct Samza progress.

I've opened a separate JIRA to track this issue: 

bq. BTW, when we think about whether the loop is required or not, it's better 
not to make the assumption we need the implementation of AMRMClientAsyncImpl, 
given it may be changed in the future. Probably we want something like that 
AMRMClientAsync can have the API block the caller until unregistration. 
Unfortunately, we don't have it on hand right now. Thoughts?

Yea, I agree. It almost feels like there should be something like 
amClient.await, but I think this should be a YARN JIRA, rather than a Samza 
one. Given that the other AMs (i.e. the dist shell example) are using an event 
loop, I think it's fine to stick with what we've got.

> Use YARN's AMRMClientAsync client library
> -----------------------------------------
>
>                 Key: SAMZA-58
>                 URL: https://issues.apache.org/jira/browse/SAMZA-58
>             Project: Samza
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Zhijie Shen
>         Attachments: SAMZA-58.1.patch, SAMZA-58.2.patch
>
>
> YARN 2.2.0 has a nice Async API for clients and AMs. This API didn't exist 
> when we did the initial YARN integration for Samza. We should upgrade Samza 
> to use these new APIs.
> The API is loosely based off Samza's own AM code, so we can probably strip 
> out a lot of it (YarnAppMaster, mainly), and switch everything over to the 
> call-back based API.
> For details, see:
> https://issues.apache.org/jira/browse/YARN-417
> This new API is used in DistributedShell now, so we can use that for testing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to