[ 
https://issues.apache.org/jira/browse/SAMZA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020524#comment-14020524
 ] 

Jakob Homan commented on SAMZA-92:
----------------------------------

In terms of the license check not catching these, it's because the docs folder 
is not part of the gradle project and instead built with its own system (shell 
scripts).  I'd recommend converting these shells scripts to be part of the 
gradle script, just to have fewer moving parts, and to integrate it into the 
license check.  We can do that in another JIRA.


> More files in need of license headers
> -------------------------------------
>
>                 Key: SAMZA-92
>                 URL: https://issues.apache.org/jira/browse/SAMZA-92
>             Project: Samza
>          Issue Type: Bug
>          Components: build, docs
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.7.0
>
>         Attachments: SAMZA-92.patch
>
>
> {noformat}Ignoring header in: 
> samza-test/src/main/java/org/apache/samza/test/integration/join/Checker.java
> Ignoring header in: 
> samza-test/src/main/java/org/apache/samza/test/integration/join/Emitter.java
> Ignoring header in: 
> samza-test/src/main/java/org/apache/samza/test/integration/join/EpochPartitioner.java
> Ignoring header in: 
> samza-test/src/main/java/org/apache/samza/test/integration/join/Joiner.java
> Ignoring header in: 
> samza-test/src/main/java/org/apache/samza/test/integration/join/Watcher.java
> Ignoring header in: 
> samza-test/src/main/java/org/apache/samza/test/integration/SimpleStatefulTask.java
> Ignoring header in: 
> samza-test/src/main/java/org/apache/samza/test/integration/StatePerfTestTask.java
> Ignoring header in: samza-test/src/main/resources/common.properties
> Ignoring header in: samza-test/src/main/resources/log4j.xml
> Ignoring header in: 
> samza-yarn/src/main/resources/scalate/css/bootstrap.min.css
> Ignoring header in: 
> samza-yarn/src/main/resources/scalate/js/bootstrap.min.js{noformat}
> The scalate files are false positives; they have a license header and are ASL 
> 2.0 licensed, so I *believe* that's ok.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to