[ 
https://issues.apache.org/jira/browse/SAMZA-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056707#comment-14056707
 ] 

Chris Riccomini commented on SAMZA-326:
---------------------------------------

[~cpsoman], are you cool with removing this fix from your SAMZA-256 patch, and 
putting it in here? Then we can commit to master, and cherry-pick into 0.7.1. 
As Jakob said, this will have to happen before SAMZA-256 goes in, or else we'll 
have branches without matching commit checksums, which I'd like to avoid.

> LevelDbKeyValueStore range implements 'from' -> 'to' instead of 'from' -> 
> 'until'
> ---------------------------------------------------------------------------------
>
>                 Key: SAMZA-326
>                 URL: https://issues.apache.org/jira/browse/SAMZA-326
>             Project: Samza
>          Issue Type: Bug
>          Components: kv
>    Affects Versions: 0.7.0
>            Reporter: Chinmay Soman
>             Fix For: 0.8.0, 0.7.1
>
>
> Most built-in ordered collection data structures in Java (SortedMap, List, 
> ...) define a range (submap / sublist) as follows:
> 'from' (inclusive) -> 'until' (exclusive)
> However, the current LevelDbKeyValueStore implementation defines range as:
> 'from' (inclusive) -> 'to' (inclusive)
> While this is not technically incorrect, I think we should change the 
> semantics to follow the norm. 
> P.S. This can easily be done by changing the '<=' comparison in 
> LevelDbRangeIterator to '<'



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to