[ 
https://issues.apache.org/jira/browse/SAMZA-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Soman updated SAMZA-345:
--------------------------------

    Description: 
Following up from SAMZA-109

We need to do the following things:

1. Add CommandBuilder.setLogDir.
2. Make ShellCommandBuilder.buildEnvironment do a string replace for task.opts 
(ENV_JAVA_OPTS) to replace $SAMZA_LOG_DIR with log dir, and 
$SAMZA_CONTAINER_NAME with container name.
3. Update SamzaAppMasterTaskManager, and ProcessJobFactory to use the new 
CommandBuilder.setLogDir method.



  was:
Currently, when the user customizes task.opts, the default settings are 
overwritten, which means - we also lose $SAMZA_LOG_DIR and 
$SAMZA_CONTAINER_NAME. 

This is discussed in detail in SAMZA-109

The initial recommendation is to do the following things

1. Add CommandBuilder.setLogDir.
2. Make ShellCommandBuilder.buildEnvironment do a string replace for task.opts 
(ENV_JAVA_OPTS) to replace $SAMZA_LOG_DIR with log dir, and 
$SAMZA_CONTAINER_NAME with container name.
3. Update SamzaAppMasterTaskManager, and ProcessJobFactory to use the new 
CommandBuilder.setLogDir method.




> Preserve log directory and container name even when task.opts is overwritten
> ----------------------------------------------------------------------------
>
>                 Key: SAMZA-345
>                 URL: https://issues.apache.org/jira/browse/SAMZA-345
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.8.0
>            Reporter: Chinmay Soman
>
> Following up from SAMZA-109
> We need to do the following things:
> 1. Add CommandBuilder.setLogDir.
> 2. Make ShellCommandBuilder.buildEnvironment do a string replace for 
> task.opts (ENV_JAVA_OPTS) to replace $SAMZA_LOG_DIR with log dir, and 
> $SAMZA_CONTAINER_NAME with container name.
> 3. Update SamzaAppMasterTaskManager, and ProcessJobFactory to use the new 
> CommandBuilder.setLogDir method.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to