[
https://issues.apache.org/jira/browse/SAMZA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069352#comment-14069352
]
Martin Kleppmann commented on SAMZA-349:
----------------------------------------
Some systems expect counter values to be always increasing, e.g. [rrdtool's
COUNTER type|http://oss.oetiker.ch/rrdtool/doc/rrdcreate.en.html#ICOUNTER]. I
just wanted to point out that some people may be depending on the existing
behaviour for integration with their metrics systems.
Personally I think that resetting every 60 seconds makes much more sense, e.g.
because it allows you to sum the rate of events in several parallel processes,
it's not so dependent on whether you're using 32-bit or 64-bit numbers, etc. So
I'm in favour of this patch, I just wanted to call out the potential
compatibility issue.
> MetricsSnapshotReporter does not refresh metrics every 60 seconds
> -----------------------------------------------------------------
>
> Key: SAMZA-349
> URL: https://issues.apache.org/jira/browse/SAMZA-349
> Project: Samza
> Issue Type: Bug
> Reporter: Yan Fang
> Assignee: Yan Fang
> Attachments: SAMZA-349.patch
>
>
> If my understanding is correct, the metrics we provide are for every 60
> seconds and all counters will be reset every 60 seconds. Current the
> MetricsSnapshotReporter seems missing this implementation. It sends out the
> metrics every 60 seconds but does not reset the counter value.
> {code}
> registry.getGroup(group).foreach {
> case (name, metric) =>
> metric.visit(new MetricsVisitor {
> def counter(counter: Counter) = groupMsg.put(name,
> counter.getCount: java.lang.Long)
> def gauge[T](gauge: Gauge[T]) = groupMsg.put(name,
> gauge.getValue.asInstanceOf[Object])
> })
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
