Chris Riccomini created SAMZA-359:
-------------------------------------
Summary: Refactor grouper packages and class names
Key: SAMZA-359
URL: https://issues.apache.org/jira/browse/SAMZA-359
Project: Samza
Issue Type: Bug
Components: container
Affects Versions: 0.8.0
Reporter: Chris Riccomini
Assignee: Chris Riccomini
Fix For: 0.8.0
After the SAMZA-123 code was committed, I have some nits about class name and
package structure that I missed in the code review.
Right now there are two packages:
# org.apache.samza.container.systemstreampartition.groupers
# org.apache.samza.container.systemstreampartition.taskname.groupers
Things I'd like to tweak:
# Some of the code related to the two packages above are scattered around
org.apache.samza.container.
# As a matter of taste, I feel that the "systemstreampartition" package name
because it's extremely long.
# For the taskname.groupers package, we have nested packages with only one
class in it, and it seems strange to have two "groupers" packages at different
levels (groupers and taskname.groupers).
# Some of the class names are a bit opaque
(SystemStreamPartitionTaskNameGrouper,
SimpleSystemStreamPartitionTaskNameGrouper).
My proposed changes:
# Eliminate the old packages (shown above), and create two new packages:
org.apache.samza.container.grouper.stream and
org.apache.samza.container.grouper.task.
# Move all stream-related grouper code into grouper.stream.
# Move all task-related grouper code into grouper.task.
# Rename SystemStreamPartitionTaskNameGrouper to TaskNameGrouper
# Rename SimpleSystemStreamPartitionTaskNameGrouper to GroupByContainerCount
--
This message was sent by Atlassian JIRA
(v6.2#6252)
