[ 
https://issues.apache.org/jira/browse/SAMZA-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083233#comment-14083233
 ] 

Yan Fang commented on SAMZA-362:
--------------------------------

A few thoughts about this:
* there is a package called samza.container in samza-core
* If we put all code happens in the container into samza-container, do we also 
put AM code there? Because technically, an AM runs in a container too. In 
addition, now AM plays more roles than it did because it's responsible for 
topic partition grouping now.
* also it gives me the impression that samza-container is a part of samza-yarn. 
Because YARN contains the concept of container.

not saying we should not do this. Just a few thoughts to discuss.


> Rename samza-core to samza-container
> ------------------------------------
>
>                 Key: SAMZA-362
>                 URL: https://issues.apache.org/jira/browse/SAMZA-362
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.8.0
>            Reporter: Chris Riccomini
>             Fix For: 0.8.0
>
>
> samza-core is a pretty generic name, and encourages people to use it as a 
> dumping ground for random things that don't fit into other packages. I've 
> never liked the name (see SAMZA-11). I'd prefer to name the package 
> samza-container so that it's clear that SamzaContainer, and all of its 
> related code lives there.
> It shouldn't be too expensive to rename the package for 0.8.0. We'll just 
> have to update hello-samza. For developers, they'll just need to tweak their 
> build scripts form samza-core to samza-container. Given that 0.8.0 is already 
> backwards-incompatible at the API level, I think this change is pretty minor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to