Repository: incubator-samza Updated Branches: refs/heads/master 5bd081146 -> 8acef467f
SAMZA-366; fix javadocs in jmx appender Project: http://git-wip-us.apache.org/repos/asf/incubator-samza/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-samza/commit/8acef467 Tree: http://git-wip-us.apache.org/repos/asf/incubator-samza/tree/8acef467 Diff: http://git-wip-us.apache.org/repos/asf/incubator-samza/diff/8acef467 Branch: refs/heads/master Commit: 8acef467ff6f929fa0b3be0f8b52b3f18a67c815 Parents: 5bd0811 Author: Chris Riccomini <[email protected]> Authored: Tue Aug 5 09:55:48 2014 -0700 Committer: Chris Riccomini <[email protected]> Committed: Tue Aug 5 09:55:48 2014 -0700 ---------------------------------------------------------------------- .../org/apache/samza/logging/log4j/JmxAppender.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-samza/blob/8acef467/samza-log4j/src/main/java/org/apache/samza/logging/log4j/JmxAppender.java ---------------------------------------------------------------------- diff --git a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/JmxAppender.java b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/JmxAppender.java index 27c9a29..428dce0 100644 --- a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/JmxAppender.java +++ b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/JmxAppender.java @@ -38,7 +38,7 @@ import org.apache.log4j.spi.LoggingEvent; * </p> * * <code> - * <appender name="jmx" class="org.apache.samza.logging.log4j.JmxAppender"/> + * <appender name="jmx" class="org.apache.samza.logging.log4j.JmxAppender"/> * </code> * * <p> @@ -46,10 +46,10 @@ import org.apache.log4j.spi.LoggingEvent; * </p> * * <code> - * <root> - * <!-- ...other stuff... --> - * <appender-ref ref="jmx" /> - * </root> + * <root> + * <!-- ...other stuff... --> + * <appender-ref ref="jmx" /> + * </root> * </code> */ public class JmxAppender extends AppenderSkeleton { @@ -66,6 +66,8 @@ public class JmxAppender extends AppenderSkeleton { /** * Calling the default constructor causes this appender to register JmxLog4J * as a JMX MBean. + * + * @param MBeanServer to be injected for unit testing. */ public JmxAppender(MBeanServer mbeanServer) { super();
